pentapiper/pupdns
1
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

packet-parsing #1

Open
pentapiper wants to merge 5 commits from packet-parsing into main
pull from: packet-parsing
merge into: pentapiper:main
Conversation 6 Commits 5 Files changed 8 -38
2 changed files with 0 additions and 38 deletions
Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 201e15348e - Show all commits

2
include/dns_packet_buffer.h
View file

@ -11,6 +11,4 @@ struct DNSPacketBuffer {
struct DNSPacketBuffer *new_dns_packet_buffer();
affine commented 2025-07-18 18:13:47 -07:00
Copy link

I think both of the structs in this file should be typedef'ed so that you dont need to write 'struct' everywhere.

I think both of the structs in this file should be typedef'ed so that you dont need to write 'struct' everywhere.
struct DNSPacketHeader *dns_header(struct DNSPacketBuffer);
unsigned char pb_read_byte(struct DNSPacketBuffer *);

36
src/dns_packet_buffer.c
View file

@ -8,39 +8,3 @@ struct DNSPacketBuffer *new_dns_packet_buffer()
buf = malloc(sizeof(struct DNSPacketBuffer));
return buf;
}
struct DNSPacketHeader *dns_header(struct DNSPacketBuffer)
{
}
// read a single byte and move the cursor one byte forward
unsigned char pb_read_byte(struct DNSPacketBuffer *pb)
{
unsigned char b = pb->buf[pb->pos];
pb->pos++;
if (pb->pos >= PB_SIZE) {
printf(
"WARN: pb_read_byte: advanced packetbuffer cursor pos to %lu, which is greater than the max %d",
pb->pos,
PB_SIZE
);
}
return b;
}
unsigned char pb_get_byte(struct DNSPacketBuffer *pb)
{
if (pb->pos >= PB_SIZE) {
printf(
"WARN: pb_get_byte: accessing packetbuffer cursor pos %lu, which is greater than the max %d",
pb->pos,
PB_SIZE
);
}
return pb->buf[pb->pos];
}